Skip to content

test: Add more test coverage of validate command's interaction with backend blocks #37977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SarahFrench wants to merge 3 commits into
base: main
Choose a base branch
from
+32 −4
Open

test: Add more test coverage of validate command's interaction with backend blocks #37977

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
22e9b4a
test: Show how the validate command doesn't detect when an unknown ba…
SarahFrench Dec 5, 2025
bb86673
test: Minor fixes to error messages when test fails
SarahFrench Dec 5, 2025
2398fe4
test: Add some TODOs in code comments
SarahFrench Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions internal/command/testdata/invalid-backend-configuration/unknown-backend-type/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
terraform {
backend "shipping-container" {}
}
33 changes: 29 additions & 4 deletions internal/command/validate_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -538,18 +538,43 @@ func TestValidate_backendBlocks(t *testing.T) {
if code != 1 {
t.Fatalf("unexpected successful exit code %d\n\n%s", code, output.Stdout())
}
if !strings.Contains(output.Stderr(), "Error: Attribute redefined") {
expectedErr := "Error: Attribute redefined"
if !strings.Contains(output.Stderr(), expectedErr) {
t.Fatalf("unexpected error content: wanted %q, got: %s",
"Error: Attribute redefined",
expectedErr,
output.Stderr(),
)
}
})

// TODO: Should this validation be added?
t.Run("NOT invalid when the backend type is unknown", func(t *testing.T) {
output, code := setupTest(t, "invalid-backend-configuration/unknown-backend-type")
if code != 0 {
t.Fatalf("expected a successful exit code %d\n\n%s", code, output.Stderr())
}
expectedMsg := "Success! The configuration is valid."
if !strings.Contains(output.Stdout(), expectedMsg) {
t.Fatalf("unexpected output content: wanted %q, got: %s",
expectedMsg,
output.Stdout(),
)
}
})

// Backend blocks aren't validated using their schemas currently.
// TODO: Should this validation be added?
Copy link
Member Author

@SarahFrench SarahFrench Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been looking into this, but I've added these TODO comments here so that it's clear these tests are defining current behaviour and not necessarily correct behaviour.

t.Run("NOT invalid when there's an unknown attribute present", func(t *testing.T) {
if output, code := setupTest(t, "invalid-backend-configuration/unknown-attr"); code != 0 {
t.Fatalf("unexpected non-successful exit code %d\n\n%s", code, output.Stderr())
output, code := setupTest(t, "invalid-backend-configuration/unknown-attr")
if code != 0 {
t.Fatalf("expected a successful exit code %d\n\n%s", code, output.Stderr())
}
expectedMsg := "Success! The configuration is valid."
if !strings.Contains(output.Stdout(), expectedMsg) {
t.Fatalf("unexpected output content: wanted %q, got: %s",
expectedMsg,
output.Stdout(),
)
}
})
}
Expand Down