test: Add more test coverage of validate command's interaction with backend blocks
#37977
+32
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SarahFrench
added
the
no-changelog-needed
These tests are here to define existing behaviour, not define desired behaviour. I wanted to make that clear!
SarahFrench
commented
Dec 15, 2025
| }) | ||
|
|
||
| // Backend blocks aren't validated using their schemas currently. | ||
| // TODO: Should this validation be added? |
Member
Author
There was a problem hiding this comment.
I've been looking into this, but I've added these TODO comments here so that it's clear these tests are defining current behaviour and not necessarily correct behaviour.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a sneaky follow-up to #37972, as I realised that I had another test case that I hadn't pushed to that branch. Also there are some refactoring and small fixes to test failure messages from the first PR.
Target Release
1.15.x
Rollback Plan
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
CHANGELOG entry