Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: huggingface/transformers
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: ebf9b7c
Choose a base ref
...
head repository: huggingface/transformers
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 3078ef3
Choose a head ref
  • 15 commits
  • 96 files changed
  • 13 contributors

Commits on Mar 24, 2025

  1. fix Gemma3 Config (#36893)

    * fix Gemma3 Config
    
    * fix config in modular gemm3
    eljandoubi authored Mar 24, 2025
    Configuration menu
    Copy the full SHA
    fe4ca2f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    48da44b View commit details
    Browse the repository at this point in the history
  3. [Fix] Add original_max_position_embeddings to YARN rope_scaling opt…

    …ional keys (#36877)
    
    [fix] Update optional keys in _validate_yarn_parameters to include original_max_position_embeddings
    JustinTong0323 authored Mar 24, 2025
    Configuration menu
    Copy the full SHA
    e28be7a View commit details
    Browse the repository at this point in the history
  4. tests: fix asyncio.wait() usage for python>=3.11 (#36898)

    tests: fix asyncio.wait() usage for python>=3.7
    
    Passing coroutings directly to `asyncio.wait()` is deprecated since
    python 3.8 and removed starting from python 3.11. Instead, it's required
    to explicitly wrap coroutine in the task with `asyncio.create_task()` which
    first appeared in python 3.7.
    
    We step into this issue running the following Transformers tests on a
    system with python 3.11 or later (for example, Ubuntu 24.04 has python 3.12):
    
    * `tests/trainer/test_trainer_distributed.py`
    * `tests/extended/test_trainer_ext.py`
    
    The error will be:
    ```
    src/transformers/testing_utils.py:2380: in execute_subprocess_async
        result = loop.run_until_complete(
    /usr/lib/python3.12/asyncio/base_events.py:687: in run_until_complete
        return future.result()
    src/transformers/testing_utils.py:2368: in _stream_subprocess
        await asyncio.wait(
    ...
    E           TypeError: Passing coroutines is forbidden, use tasks explicitly.
    
    ```
    
    See: https://docs.python.org/3.10/library/asyncio-task.html#asyncio.wait
    See: https://docs.python.org/3.10/library/asyncio-task.html#asyncio.wait
    See: https://docs.python.org/3.7/library/asyncio-task.html#asyncio.create_task
    
    Signed-off-by: Dmitry Rogozhkin <dmitry.v.rogozhkin@intel.com>
    Co-authored-by: Yih-Dar <2521628+ydshieh@users.noreply.github.com>
    dvrogozh and ydshieh authored Mar 24, 2025
    Configuration menu
    Copy the full SHA
    a41e08a View commit details
    Browse the repository at this point in the history
  5. [chameleon] fix num image token check (#36918)

    * [chameleon] fix num image token check
    
    * embed after merging image token
    
    * skip this also
    
    * mistral require_read_token
    zucchini-nlp authored Mar 24, 2025
    Configuration menu
    Copy the full SHA
    57f551c View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    9e125d9 View commit details
    Browse the repository at this point in the history
  7. Use another repo. for Mistral3 processor testing (#36925)

    * fix
    
    * fix
    
    * fix
    
    * fix
    
    ---------
    
    Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
    ydshieh and ydshieh authored Mar 24, 2025
    Configuration menu
    Copy the full SHA
    340500b View commit details
    Browse the repository at this point in the history
  8. Fix typos (#36910)

    * fix typos
    
    * fix typos
    
    * fix typos
    
    * fix typos
    omahs authored Mar 24, 2025
    Configuration menu
    Copy the full SHA
    cbf924b View commit details
    Browse the repository at this point in the history
  9. Update trainer_pt_utils.py docstrings for consistency (#36912)

    * Update trainer_pt_utils.py
    
    * update docstrings trainer_pt_utils.py for consistency
    
    * Update src/transformers/trainer_pt_utils.py
    
    ---------
    
    Co-authored-by: Matt <Rocketknight1@users.noreply.github.com>
    ethanknights and Rocketknight1 authored Mar 24, 2025
    Configuration menu
    Copy the full SHA
    a6ecb54 View commit details
    Browse the repository at this point in the history
  10. [2/N] Use pyupgrade --py39-plus to improve code (#36857)

    Use pyupgrade --py39-plus to improve code
    cyyever authored Mar 24, 2025
    Configuration menu
    Copy the full SHA
    00d0772 View commit details
    Browse the repository at this point in the history
  11. Fix pytorch defomr attn path (#36923)

    * Fix pytorch path for DeformableAttention
    
    * Apply for GroundingDino
    qubvel authored Mar 24, 2025
    Configuration menu
    Copy the full SHA
    2be2984 View commit details
    Browse the repository at this point in the history
  12. More precise comment (#36935)

    * fix
    
    * fix
    
    ---------
    
    Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
    ydshieh and ydshieh authored Mar 24, 2025
    Configuration menu
    Copy the full SHA
    5932606 View commit details
    Browse the repository at this point in the history
  13. Added support for seed in DataCollatorForWholeWordMask, and also wr…

    …ote tests.
    
    Also fixed bugs where the code hardcoded values for mask replacement probability and random replacement probability, instead of using the values passed by the user.
    capemox authored and Rocketknight1 committed Mar 24, 2025
    Configuration menu
    Copy the full SHA
    a8e7283 View commit details
    Browse the repository at this point in the history
  14. formatting issues

    capemox authored and Rocketknight1 committed Mar 24, 2025
    Configuration menu
    Copy the full SHA
    a5526d0 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    3078ef3 View commit details
    Browse the repository at this point in the history
Loading