[Fix] Add original_max_position_embeddings to YARN rope_scaling optional keys
#36877
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds support for the
original_max_position_embeddingsparameter in YARN rope scaling configurations, addressing compatibility issues with Qwen-32B series models.The Qwen team requires this parameter for their YARN implementation in Qwen-32B models, ref: link.
Previously, transformers would raise warnings about unrecognized keys despite this being a valid configuration parameter:
Impact of this PR:
This PR could also solves downstream issues:
sgl-project/sglang#4145
vllm-project/vllm#10293
Clarify #33783
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.