Remove outdated FIXME comment in RhythmRuler _undo() #4858
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'FIXME: Add undo for REST' comment is outdated because the feature is already implemented at lines 1735-1739 (now 1734-1738). The undo for REST toggles the rest state back using __toggleRestState().
Contributor
|
❌ Some Jest tests failed. Please check the logs and fix the issues before merging. Failed Tests: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes an outdated FIXME comment in
js/widgets/rhythmruler.js.Details
The comment
// FIXME: Add undo for RESTwas misleading, as undo functionalityfor REST operations is already implemented in the
_undo()logic.Removing the comment avoids confusion for future contributors and keeps the
codebase accurate.
Changes
_undo()Testing
No functional changes; manual inspection only.