Optimise LiteralType.__eq__ and __hash__ #20423
Draft
+2
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If I'm doing it right, this should be 2% on a profile I'm looking at
hauntsaninja
force-pushed
the
mypylit
branch
from
0467d28 to
f3f79f6
Compare
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
ilevkivskyi
reviewed
Dec 17, 2025
| if self._hash == -1: | ||
| self._hash = hash((self.value, self.fallback)) | ||
| return self._hash | ||
| return hash(self.value) |
Member
There was a problem hiding this comment.
Is this part actually safe? This will make Literal["foo"] and Literal[b"foo"] have same hash (I don't remember why, but we always store the literal bytes value as a string).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If I'm doing it right, this should be 1-2% on a profile I'm looking at