Split aws sync into two commands; make sure hidden security.txt is synced #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pww217
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alright this took a bit of testing as you can see from the commits.
It's a bit tricky because I want it to delete items in
assets/that may be removed so we don't have to manually, but when I tried that in the root of the bucket, it deleted all the builds and examples too...So I specified more targeted commands and it seems to work fine. We'll have to see how scalable this is as the project grows, however. It may be that we need to restructure a bit, although this is the only repo that executes
s3 syncin the root directory so likely the only cause of issues.I think this setup is perfectly safe but we may need to review from time to time if the bucket structure sees major changes.