assorted (test) cleanups #88
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tests have to be in their own package to prevent a circular import between testdigest and the main module, but Go allows for blackbox-testing by using a "_test" package. This patch: - moves the test file to be next to the implementation. - removes the redundant imports of "crypto/sha256" and "crypto/shasha512", as they are imported by default since 084376b Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Keep the linters happy: - fix an unhandled error (but unlikely to happen) - fix some variables being shadowed Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Use sub-tests to not fail early if an algorithm fails.
With this change:
=== RUN TestFroms
=== RUN TestFroms/sha256
=== RUN TestFroms/sha384
=== RUN TestFroms/sha512
--- PASS: TestFroms (0.02s)
--- PASS: TestFroms/sha256 (0.01s)
--- PASS: TestFroms/sha384 (0.00s)
--- PASS: TestFroms/sha512 (0.00s)
PASS
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
requested review from
AkihiroSuda,
dmcgowan,
stevvooe and
vbatts
as code owners
vbatts
approved these changes
Aug 1, 2023
dmcgowan
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some changes I had locally (got some more, but in a follow-up) 😄
move digest tests to root
These tests have to be in their own package to prevent a circular import
between testdigest and the main module, but Go allows for blackbox-testing
by using a "_test" package.
This patch:
as they are imported by default since 084376b
TestFroms: fix some linting issues
Keep the linters happy:
TestFroms: use sub-tests
Use sub-tests to not fail early if an algorithm fails.
With this change:
gofmt, and touch-up some godoc