fix deprecation of NewDigestFromHex and Digest.Hex #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Both of these were deprecated in 55f6758, but the format of the GoDoc comments didn't follow the correct format, which causes them not being picked up by tools as "deprecated". This patch: - Fixes the comments to be in the right format. - Updates uses in the codebase to use the alternatives. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
requested review from
AkihiroSuda,
dmcgowan,
stevvooe and
vbatts
as code owners
Member
Author
|
@vbatts @AkihiroSuda @stevvooe ptal |
thaJeztah
commented
Nov 8, 2022
| // not hex | ||
| Input: "sha256:d41d8cd98f00b204e9800m98ecf8427e", | ||
| Err: digest. ErrDigestInvalidLength, | ||
| Err: digest.ErrDigestInvalidLength, |
Member
Author
There was a problem hiding this comment.
Was surprised this actually worked, but apparently spaces are accepted (TIL!)
This was referenced Nov 8, 2022
AkihiroSuda
approved these changes
Nov 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both of these were deprecated in 55f6758 (#33), but the format of the GoDoc comments didn't follow the correct format, which causes them not being picked up by tools as "deprecated".
This patch:
Also gofmt'd the code (first commit)