Improve licensing of tests source code #589
Conversation
Provide Apache Public License v2.0 provided template to all the tests source code files. The copyright notice part needs to get replaced with the correct copyright holders and years. Signed-off-by: Silvano Cirujano Cuesta <silvano.cirujano-cuesta@siemens.com>
|
Hi @Silvanoc thank you for your PR and the email to dev@! There is some excellent guidance provided by an LF Legal team member and open source copyright expert that you might find useful: https://www.linuxfoundation.org/blog/blog/copyright-notices-in-open-source-software-projects Would you be open to amending your PR to generalize the copyright notice? |
@jorydotcom thanks, I wasn't aware of it.
Of course! That is exactly the intention! Though I would prefer to stick to providing the template in my commit and a project maintainer adds a commit with the desired copyright notice. Then I'd mark the PR as ready for review. Ideally a list of contributors is also kept in which organizations can be entered. I've added a 2nd commit with that proposal? Reason for that? Because with the German working regulation that applies to my contributions, I am author, and my company is copyright holder. |
Add CONTRIBUTORS file to track contributors for copyright purposes. This file differentiates between: - Individual: which are simultaneously authors and copyright holders - Organizations: which might hold the copyright of their employees according their local regulations Signed-off-by: Silvano Cirujano Cuesta <silvano.cirujano-cuesta@siemens.com>
2 participants
The source code files for the conformance tests don’t provide the typical Apache v2.0 licensing headers. The copyright holders are not explicitly listed either. It would make sense to have them for clearer licensing, simplifying contributions and reuse.
This PR adds the licensing headers provided by the Apache v2.0 license itself. It should also add the corresponding copyright holders.
This information should also help ensuring that the license information does not get lost, if someone comes to the idea of only copying the directory with the conformance tests.
Disclaimer: I am not a lawyer.