integration tests: detect and Log Docker Hub Rate limit Failures

[medyagh]

it should Log something simple instead of we search through logs for the docker rate limit

Example this Gopogh Report
https://storage.googleapis.com/minikube-builds/logs/21439/41161/Docker_Linux_containerd.html

Warning  Failed     7m14s (x2 over 7m57s)   kubelet            Failed to pull image "docker.io/nginx:alpine": failed to pull and unpack image "docker.io/library/nginx:alpine": failed to copy: httpReadSeeker: failed open: unexpected status code https://registry-1.docker.io/v2/library/nginx/manifests/sha256:60e48a050b6408d0c5dd59b98b6e36bf0937a0bbe99304e3e9c0e63b7563443a: 429 Too Many Requests - Server message: toomanyrequests: You have reached your unauthenticated pull rate limit. https://www.docker.com/increase-rate-limit

also there is probably a WAY to check how many Docker API calls we have left before Banned, so we can log that in the beggninign of the test and potentially even Wait for it before running the test and wassting time

[shrimptails-f]

@medyagh
Hello! Thank you for maintaining this amazing project.
I'm a new contributor and would love to help improve this wonderful community.
I'd like to discuss the implementation approach for this issue.
While I haven't fully explored the minikube codebase yet, I'm considering the following approaches:

1. Detect from HTTP status code during image pull
   Docker officially documents the status codes and messages in their documentation: https://docs.docker.com/docker-hub/usage/

2. Error message string matching pattern
   Parse error messages for rate limit indicators

Would you have any suggestions for better approaches or implementation patterns that would fit well with the existing minikube architecture?
Also, could you please assign this issue to me? I'd be happy to work on this.

[henry3260]

/assign

[henry3260]

Hi @medyagh, thanks for assigning me this issue.
From what I’ve checked, the changes should be in cache_images.go.
I plan to add code to scan the error message for a 429 error.
Could you please confirm if I’m looking at the right place before I proceed?
Thanks!