Skip to content

Conversation

@thockin
Copy link
Member

@thockin thockin commented Jul 29, 2023

It says amd64, but calls all-build

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 29, 2023
@k8s-ci-robot k8s-ci-robot requested review from nan-yu and stp-ip July 29, 2023 17:41
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 29, 2023
@justinsb
Copy link
Member

Good catch & I really like this. There's a choice in how we name the github actions "jobs", and I have previously proposed mapping them 1:1 to scripts under (for example) dev/ci - with the intention that then it becomes easy to run locally when needed. But if we're using make it makes a lot more sense to align them with the make targets.

(We might want to consider naming the thing which calls make all-build -> all-build, therefore, but now I'm just nit-picking)

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 29, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 9163f8f into kubernetes:master Jul 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants