Skip to content

Conversation

@thockin
Copy link
Member

@thockin thockin commented Jul 6, 2023

This include symlinks from /bin -> /usr/bin (and lib, and ...), which broke the build script. See comments in there for details.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 6, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from nan-yu and stp-ip July 6, 2023 00:33
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 6, 2023
@thockin thockin added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 6, 2023
@thockin
Copy link
Member Author

thockin commented Jul 6, 2023

Hmm, unexpected e2e fails.

@thockin
Copy link
Member Author

thockin commented Jul 6, 2023

Harumph, this expects /bin to be a symlink, but distroless has a real dir there, resulting in a collision. Not sure how to fix it. Will have to think.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 7, 2023
@thockin
Copy link
Member Author

thockin commented Jul 7, 2023

Passes e2e now, final image size is 65.8 MB. Far too manual, but <shrug>

@thockin thockin removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 7, 2023
@thockin thockin force-pushed the master branch 2 times, most recently from 1055e74 to a0699d1 Compare July 7, 2023 03:36
thockin added 2 commits July 10, 2023 12:06
This include symlinks from /bin -> /usr/bin (and lib, and ...), which
broke the build script.  See comments in there for details.
@thockin thockin merged commit 0ae6c31 into kubernetes:master Jul 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants