Added name validation in meta #67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtsykun
force-pushed
the
meta-name-validation
branch
from
22886a9 to
6737188
Compare
vtsykun
force-pushed
the
meta-name-validation
branch
from
6737188 to
4842fff
Compare
f3ath
reviewed
Oct 15, 2017
|
|
||
| private function isValidMemberName(string $name): bool | ||
| { | ||
| return preg_match('/^(?=[^-_ ])[a-zA-Z0-9\x{0080}-\x{FFFF}-_ ]*(?<=[^-_ ])$/u', $name) === 1; |
Contributor
There was a problem hiding this comment.
Now this line is duplicated here and in ResourceObject.I suggest we move this check into a trait unless we can figure out a better solution
f3ath
reviewed
Oct 15, 2017
|
|
||
| private function validateObject($object) | ||
| { | ||
| foreach ($object as $name => $value) { |
Contributor
There was a problem hiding this comment.
What if $object implements Iterator and the keys and values exposed by Iterator interface are different from its JSON representation. We may perhaps do json_encode right in the constructor, then convert it back to an array with json_decode(), and then check the keys of the resulting array.
Contributor
|
Hi @vtsykun, thanks for the PR. I left a couple of comment in the code. Please let me know what you think. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix ticket #63