Skip to content

Conversation

@i3hz
Copy link
Contributor

@i3hz i3hz commented Oct 26, 2025

What does this PR do?

Fixes #41738

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@zucchini-nlp

@i3hz i3hz mentioned this pull request Oct 26, 2025
4 tasks
@github-actions
Copy link
Contributor

[For maintainers] Suggested jobs to run (before merge)

run-slow: florence2

@i3hz
Copy link
Contributor Author

i3hz commented Oct 27, 2025

@vasqu I don't know who to ping lol can you please look into this

@vasqu
Copy link
Contributor

vasqu commented Oct 27, 2025

@zucchini-nlp is the right person but she's out for a bit. Maybe checking in with the original author @ducviet00

Looks simple enough

Copy link
Contributor

@ducviet00 ducviet00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

Copy link
Contributor

@vasqu vasqu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx, just to be sure: Do we need the if check or shouldn't it always default to bart?

@i3hz
Copy link
Contributor Author

i3hz commented Oct 29, 2025

Thx, just to be sure: Do we need the if check or shouldn't it always default to bart?

Atm we don't really need the if check , but I've added it just in case . Should I remove it?

@vasqu
Copy link
Contributor

vasqu commented Oct 29, 2025

Nah it's fine, let's see if different remote models come along with a different text backbone and fix then if needed

@vasqu vasqu enabled auto-merge (squash) October 29, 2025 12:58
@vasqu vasqu merged commit 259d174 into huggingface:main Oct 29, 2025
14 checks passed
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@i3hz i3hz deleted the florence branch October 30, 2025 12:14
i3hz added a commit to i3hz/transformers that referenced this pull request Oct 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

KeyError: 'florence2_language'

4 participants