-
Notifications
You must be signed in to change notification settings - Fork 31.4k
Fix Florence2 conversion script model_type KeyError #41866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
[For maintainers] Suggested jobs to run (before merge) run-slow: florence2 |
|
@vasqu I don't know who to ping lol can you please look into this |
|
@zucchini-nlp is the right person but she's out for a bit. Maybe checking in with the original author @ducviet00 Looks simple enough |
ducviet00
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
vasqu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx, just to be sure: Do we need the if check or shouldn't it always default to bart?
Atm we don't really need the if check , but I've added it just in case . Should I remove it? |
|
Nah it's fine, let's see if different remote models come along with a different text backbone and fix then if needed |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
hopefully fixed florence2_language keyerror
What does this PR do?
Fixes #41738
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@zucchini-nlp