flash attn pytest marker #41781
Merged
flash attn pytest marker #41781
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
vasqu
approved these changes
Oct 22, 2025
Contributor
vasqu
left a comment
vasqu
left a comment
There was a problem hiding this comment.
Imo, yes as FA3 has more restrictions than FA2 so would be nice to differentiate them in tests --> can quickly check what is quirky about FA3 :D
If it's too annoying, I don't mind fusing more of a preference tbh
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: exaone4, idefics2, ministral, mistral, qwen2, qwen2_5_omni, qwen2_5_vl, qwen2_vl, qwen3, qwen3_omni_moe, qwen3_vl_moe, video_llama_3, autoawq |
ngazagna-qc
pushed a commit
to ngazagna-qc/transformers
that referenced
this pull request
Oct 23, 2025
* flash attn marker * 111 --------- Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
i3hz
pushed a commit
to i3hz/transformers
that referenced
this pull request
Oct 30, 2025
* flash attn marker * 111 --------- Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
A first step toward making flash attn test again 🔥
@vasqu Do we really need to have both
or we can have only
@pytest.mark.flash_attn_testwhich cover both?