🚨 [v5] Delete feature extractors used for vision #41174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Nice, IIRC there were a few utils in processing handling that involved using the |
Member
Author
|
Yeah, the tests are failing, I will do one more round of cleaning |
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: auto |
Member
Author
|
Done |
gante
approved these changes
Sep 30, 2025
Contributor
gante
left a comment
gante
left a comment
There was a problem hiding this comment.
LGTM 🤗 🧹 🧹 🧹
(probably needs a few more deletions, looking at the CI issues)
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
vijayabhaskar-ev
pushed a commit
to vijayabhaskar-ev/transformers
that referenced
this pull request
Oct 2, 2025
* bye bye * remove from docs * do not use feature extractor here * fix docs * do not delete it * forgot these
yuchenxie4645
pushed a commit
to yuchenxie4645/transformers
that referenced
this pull request
Oct 4, 2025
* bye bye * remove from docs * do not use feature extractor here * fix docs * do not delete it * forgot these
Open
AhnJoonSung
pushed a commit
to AhnJoonSung/transformers
that referenced
this pull request
Oct 12, 2025
* bye bye * remove from docs * do not use feature extractor here * fix docs * do not delete it * forgot these
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
As per title, let's clean up for v5
These were supposed to be deleted anyway and we had the warning logged for a long time, even before I joined. Feature Extractors are now reserved for audio models only