Fix key mapping for VLMs #39029
Merged
Fix key mapping for VLMs #39029
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Member
zucchini-nlp
left a comment
zucchini-nlp
left a comment
There was a problem hiding this comment.
Thanks, indeed it doesn't handle when users inherit from VLM classes. Can you also update a similar line in self.save_pretrained?
Contributor
Author
|
Hi @zucchini-nlp ! Thank you for reviewing my PR. Yes, I’ve also updated the corresponding line in |
zucchini-nlp
added
the
for patch
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
zucchini-nlp
approved these changes
Jul 1, 2025
Cyrilvallez
pushed a commit
that referenced
this pull request
Jul 4, 2025
* fix key mapping for VLMs * use __mro__ instead * update key mapping in save_pretrained
Contributor
|
Insane PR, thanks a lot @bvantuan, wasn't aware of mro[:-1] when I proposed the key mapping patch ! |
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
* fix key mapping for VLMs * use __mro__ instead * update key mapping in save_pretrained
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
* fix key mapping for VLMs * use __mro__ instead * update key mapping in save_pretrained
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
* fix key mapping for VLMs * use __mro__ instead * update key mapping in save_pretrained
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
* fix key mapping for VLMs * use __mro__ instead * update key mapping in save_pretrained
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
* fix key mapping for VLMs * use __mro__ instead * update key mapping in save_pretrained
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
* fix key mapping for VLMs * use __mro__ instead * update key mapping in save_pretrained
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
* fix key mapping for VLMs * use __mro__ instead * update key mapping in save_pretrained
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #39004
Fixes key mapping for VLMs when they are extended by a custom subclass.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@zucchini-nlp