Skip to content

Fix init empty weights without accelerate #37337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Cyrilvallez merged 8 commits into from
Apr 7, 2025
Merged

Fix init empty weights without accelerate #37337

Cyrilvallez merged 8 commits into from
Apr 7, 2025

Conversation

@Cyrilvallez
Copy link
Member

@Cyrilvallez Cyrilvallez commented Apr 7, 2025

What does this PR do?

As per the title. People started reporting the issue as they sometimes uses Transformers without Accelerate

@github-actions
Copy link
Contributor

github-actions bot commented Apr 7, 2025

Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. The CI will be paused while the PR is in draft mode. When it is ready for review, please click the Ready for review button (at the bottom of the PR page). This will assign reviewers and trigger CI.

@github-actions github-actions bot marked this pull request as draft April 7, 2025 08:40
@Cyrilvallez Cyrilvallez marked this pull request as ready for review April 7, 2025 08:59
@Cyrilvallez Cyrilvallez added the for patch Tag issues / labels that should be included in the next patch label Apr 7, 2025
@github-actions github-actions bot requested review from MekkCyber and SunMarc April 7, 2025 08:59
ArthurZucker
ArthurZucker approved these changes Apr 7, 2025
View reviewed changes
Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you just include at the top of the file that this was copied from accelerate and link to the accelerate file Thanks

MekkCyber
MekkCyber approved these changes Apr 7, 2025
View reviewed changes
Copy link
Contributor

@MekkCyber MekkCyber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good ! Thanks

src/transformers/integrations/accelerate.py Outdated
Comment on lines 151 to 156
def values(self):
warnings.warn(
"The 'values' method of FindTiedParametersResult is deprecated and will be removed in Accelerate v1.3.0. ",
FutureWarning,
)
return sum([x[1:] for x in self], [])
Copy link
Contributor

@MekkCyber MekkCyber Apr 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit not sure if we should replace this warning

Copy link
Member Author

@Cyrilvallez Cyrilvallez Apr 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean, remove it entirely? We can as we do not expect people to use this function, it's simply internal

Copy link
Contributor

@MekkCyber MekkCyber Apr 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I think so

Copy link
Collaborator

@ArthurZucker ArthurZucker Apr 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this or warning once

SunMarc
SunMarc approved these changes Apr 7, 2025
View reviewed changes
Copy link
Member

@SunMarc SunMarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@Cyrilvallez Cyrilvallez mentioned this pull request Apr 7, 2025
Closed
4 tasks
@Cyrilvallez Cyrilvallez merged commit 08f3677 into main Apr 7, 2025
19 of 21 checks passed
@Cyrilvallez Cyrilvallez deleted the add-init-empty-weights branch April 7, 2025 09:37
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Apr 7, 2025

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@Samoed Samoed mentioned this pull request Apr 7, 2025
Closed
@jamie-rasmussen jamie-rasmussen mentioned this pull request Apr 7, 2025
Merged
vasqu pushed a commit to vasqu/transformers that referenced this pull request Apr 7, 2025
@Cyrilvallez @vasqu
Fix init empty weights without accelerate (huggingface#37337)
af10969 
* add the integration

* Update accelerate.py

* Update accelerate.py

* add find_tied_params as well

* Update accelerate.py

* add where copied from

* simplify

* add error
@ArthurZucker ArthurZucker mentioned this pull request Apr 7, 2025
Closed
ArthurZucker pushed a commit that referenced this pull request Apr 7, 2025
@Cyrilvallez @ArthurZucker
Fix init empty weights without accelerate (#37337)
4f536ba 
* add the integration

* Update accelerate.py

* Update accelerate.py

* add find_tied_params as well

* Update accelerate.py

* add where copied from

* simplify

* add error
@Tremeschin Tremeschin mentioned this pull request Apr 8, 2025
Closed
@Davidyz Davidyz mentioned this pull request Apr 17, 2025
Closed
cyr0930 pushed a commit to cyr0930/transformers that referenced this pull request Apr 18, 2025
@Cyrilvallez
Fix init empty weights without accelerate (huggingface#37337)
bfeb791 
* add the integration

* Update accelerate.py

* Update accelerate.py

* add find_tied_params as well

* Update accelerate.py

* add where copied from

* simplify

* add error
zucchini-nlp pushed a commit to zucchini-nlp/transformers that referenced this pull request May 14, 2025
@Cyrilvallez @zucchini-nlp
Fix init empty weights without accelerate (huggingface#37337)
5fae412 
* add the integration

* Update accelerate.py

* Update accelerate.py

* add find_tied_params as well

* Update accelerate.py

* add where copied from

* simplify

* add error
ceteri added a commit to DerwenAI/strwythura that referenced this pull request Aug 28, 2025
@ceteri
downgrading the transformers library due to huggingface/transformers#…
d975b83 
…37337
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ArthurZucker ArthurZucker ArthurZucker approved these changes

@MekkCyber MekkCyber MekkCyber approved these changes

@SunMarc SunMarc SunMarc approved these changes

Assignees

No one assigned

Labels

for patch Tag issues / labels that should be included in the next patch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Cyrilvallez @HuggingFaceDocBuilderDev @ArthurZucker @SunMarc @MekkCyber