Skip to content

Conversation

@cyyever
Copy link
Contributor

@cyyever cyyever commented Mar 26, 2025

Use torch.expm1(x) instead of torch.exp(x) - 1. It is more accurate for small values of x.

@github-actions github-actions bot marked this pull request as draft March 26, 2025 07:47
@github-actions
Copy link
Contributor

Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. The CI will be paused while the PR is in draft mode. When it is ready for review, please click the Ready for review button (at the bottom of the PR page). This will assign reviewers and trigger CI.

@cyyever cyyever marked this pull request as ready for review March 26, 2025 08:11
@github-actions github-actions bot requested a review from eustlb March 26, 2025 08:11
Copy link
Member

@Rocketknight1 Rocketknight1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thank you for the update!

@Rocketknight1 Rocketknight1 merged commit 78afa1c into huggingface:main Mar 26, 2025
12 checks passed
@cyyever cyyever deleted the expm1 branch March 26, 2025 14:45
zucchini-nlp pushed a commit to zucchini-nlp/transformers that referenced this pull request May 14, 2025
soghomon-b pushed a commit to soghomon-b/transformers that referenced this pull request Aug 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants