Skip to content

Conversation

@cyyever
Copy link
Contributor

@cyyever cyyever commented Mar 25, 2025

Target ruff to py3.9

@github-actions github-actions bot marked this pull request as draft March 25, 2025 16:27
@github-actions
Copy link
Contributor

Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. The CI will be paused while the PR is in draft mode. When it is ready for review, please click the Ready for review button (at the bottom of the PR page). This will assign reviewers.

@cyyever cyyever marked this pull request as ready for review March 25, 2025 16:28
@Rocketknight1
Copy link
Member

cc @ydshieh since I think this might affect the CI as well!

Copy link
Collaborator

@ydshieh ydshieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

This looks fine as it makes sure the proposed changes are compatible with a specific python version (that we want to support).

Not affecting CI IMO, so merge it.

@ydshieh ydshieh merged commit ba53127 into huggingface:main Mar 25, 2025
9 checks passed
@cyyever cyyever deleted the ruff_version branch March 26, 2025 06:24
zucchini-nlp pushed a commit to zucchini-nlp/transformers that referenced this pull request May 14, 2025
soghomon-b pushed a commit to soghomon-b/transformers that referenced this pull request Aug 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants