Skip to content

fix: validate replace_triggered_by attribute references #38010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
vietcgi wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: validate replace_triggered_by attribute references #38010

vietcgi wants to merge 1 commit into from
+88 −3

Conversation

@vietcgi
Copy link
Contributor

@vietcgi vietcgi commented Dec 13, 2025

Summary

  • replace_triggered_by now reports an error when given an invalid attribute reference that does not exist in the target resource

Test plan

  • Added unit test TestContext2Plan_triggeredByInvalidAttribute
  • Existing replace_triggered_by tests pass
  • Manual testing with null_resource confirms invalid references now produce errors
  • Valid attribute references continue to work correctly

Fixes #36740

@vietcgi vietcgi requested a review from a team as a code owner December 13, 2025 12:21
@crw crw added the bug label Dec 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

replace_triggered_by doesn't report error if given attribute references don't exist

2 participants

@vietcgi @crw