Skip to content

PSS: Swap to gating the experimental feature using configuration, instead of CLI flags #38007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SarahFrench wants to merge 6 commits into
base: main
Choose a base branch
from
+189 −136
Open

PSS: Swap to gating the experimental feature using configuration, instead of CLI flags #38007

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0b6e9b0
test: Fix pre-existing subtest name
SarahFrench Dec 12, 2025
49f2487
refactor: Gate pluggable state storage experiment behind the experime…
SarahFrench Dec 12, 2025
a881941
test: Add a new test that shows PSS cannot be used if the `pluggable_…
SarahFrench Dec 12, 2025
d5a6171
test: Make tests tolerant of warnings in the returned diagnostics
SarahFrench Dec 12, 2025
cac915f
fix: Avoid losing diagnostics raised when we parse config in `(c *Ini…
SarahFrench Dec 12, 2025
88c71b7
test: Fix test and update override files to not include any experimen…
SarahFrench Dec 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
test: Fix pre-existing subtest name
  • Loading branch information
@SarahFrench
SarahFrench committed Dec 15, 2025
commit 0b6e9b05ee613863cb47e7dfa5a4edb59c0f1175
2 changes: 1 addition & 1 deletion internal/configs/experiments_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ func TestExperimentsConfig(t *testing.T) {
t.Errorf("wrong error\n%s", diff)
}
})
t.Run("concluded", func(t *testing.T) {
t.Run("unknown", func(t *testing.T) {
parser := NewParser(nil)
parser.AllowLanguageExperiments(true)
_, diags := parser.LoadConfigDir("testdata/experiments/unknown")
Expand Down