Skip to content

Conversation

@tgross
Copy link
Member

@tgross tgross commented Dec 15, 2025

Ensure we safely handle a nil DeploymentState when copying.

Fixes: #27261

Contributor Checklist

  • Changelog Entry If this PR changes user-facing behavior, please generate and add a
    changelog entry using the make cl command.
  • Testing Please add tests to cover any new functionality or to demonstrate bug fixes and
    ensure regressions will be caught.
  • Documentation If the change impacts user-facing functionality such as the CLI, API, UI,
    and job configuration, please update the Nomad product documentation, which is stored in the
    web-unified-docs repo. Refer to the web-unified-docs contributor guide for docs guidelines.
    Please also consider whether the change requires notes within the upgrade
    guide
    . If you would like help with the docs, tag the nomad-docs team in this PR.

Reviewer Checklist

  • Backport Labels Please add the correct backport labels as described by the internal
    backporting document.
  • Commit Type Ensure the correct merge method is selected which should be "squash and merge"
    in the majority of situations. The main exceptions are long-lived feature branches or merges where
    history should be preserved.
  • Enterprise PRs If this is an enterprise only PR, please add any required changelog entry
    within the public repository.
  • If a change needs to be reverted, we will roll out an update to the code within 7 days.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Ensure we safely handle a nil `DeploymentState` when copying.

Fixes: #27261
@tgross tgross force-pushed the 27261-nil-pointer-in-dstate-copy branch from f849400 to 118e0d3 Compare December 15, 2025 13:49
@tgross tgross added the backport/1.11.x backport to 1.11.x release line label Dec 15, 2025
@tgross tgross requested a review from pkazmierczak December 15, 2025 13:49
@tgross tgross marked this pull request as ready for review December 15, 2025 13:49
@tgross tgross requested review from a team as code owners December 15, 2025 13:49
@tgross tgross requested a review from gulducat December 15, 2025 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport/1.11.x backport to 1.11.x release line

Projects

None yet

Development

Successfully merging this pull request may close these issues.

nil pointer dereference when deploying CSI node plugin

1 participant