Add TLS on ConsulIngressListener #16752
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
ConsulGatewayTLSSDSConfigstruct and corresponding receiver functions (Copy()andEqual())TLSfield toConsulIngressListenerstruct and updated its receiver functions.jobspec/parse_service.goTesting Changes
To test these changes you need to build a Nomad binary and deploy a cluster with both Nomad and Consul agents and clients.
When you have your cluster running you can run the following job-spec:
Once the job is running and healthy, use Consul's API to get the terminating gateway's configuration:
curl --request GET http://127.0.0.1:8500/v1/config/ingress-gateway | json_ppYou will get the following JSON output:
[ { "Kind": "ingress-gateway", "Name": "my-ingress-service", "TLS": { "Enabled": false }, "Listeners": [ { "Port": 8080, "Protocol": "tcp", "TLS": { "Enabled": false, "SDS": { "ClusterName": "foo", "CertResource": "example.com-public-cert" } }, "Services": [ { "Name": "uuid-api", "Hosts": null, "TLS": {}, "RequestHeaders": {}, "ResponseHeaders": {} } ] } ], "Defaults": { "MaxConnections": 0, "MaxPendingRequests": 0, "MaxConcurrentRequests": 0 }, "CreateIndex": 51, "ModifyIndex": 647 } ]Demo Video
ConsulIngressListener.mp4