llama-fit-params: QoL impr. for prints/errors #18089
Merged
+20
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohannesGaessler
force-pushed
the
llama-fp-qol
branch
3 times, most recently
from
bc0c710 to
8430344
Compare
Collaborator
Author
|
Fixes #18084 . I added handling of fit failure. |
JohannesGaessler
changed the title
|
The error handling is much better now (I tried two scenarios - the unknown tensor type quant and the nonexistent path). Both the error is there and the return code is also 1. Thank you. |
ggerganov
approved these changes
Dec 16, 2025
Member
ggerganov
left a comment
ggerganov
left a comment
There was a problem hiding this comment.
Btw, generally printf() is more widely adopted in the codebase compared to std::cout, so for consistency consider using it instead.
JohannesGaessler
force-pushed
the
llama-fp-qol
branch
from
8430344 to
80c1914
Compare
JohannesGaessler
force-pushed
the
llama-fp-qol
branch
from
80c1914 to
bbd234e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to improve usability of
llama-fit-params, add a slight delay to avoid stdout and stderr being printed out-of-order and add double quotes around the tensor buft overrides so that they can simply be copypasted.