convert : move rope_parameters to TextModel class #18061
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngxson
reviewed
Dec 15, 2025
Collaborator
ngxson
left a comment
ngxson
left a comment
There was a problem hiding this comment.
hmm, that's strange, the "text_config" should already moved to root-level config inside TextModel.__init__()
Maybe a better fix it to only populate this rope_parameters inside TextModel? Vision models doesn't seem to use it
Collaborator
Author
This is in
Hmmm, could be... |
Collaborator
Author
Yep, much better. |
CISC
changed the title
tdakhran
approved these changes
Dec 15, 2025
ngxson
approved these changes
Dec 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #18013
Fixes multimodal model configs.