Fix regex patterns for inline double dollar #2806
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2805
Here is what happened before with the input
hello $$x$$:RE_DOLLAR_INLINEregex matches, but only on the internal expression (The fix was as easy as adding an optional additional dollar in the expression.
Now, all of these should match as before:
But for
$$x$$andtext $$x$$ text, the capture group should include the dollars.