Fix commit validation workflow #6593
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frequently when run against non-main branches, commits have been backported with a `[<branch name>]` prefix in their title(s). This can easily cause them to run over the title-length checker action. Fix this by restricting it to only running on pull requests targeted at the `main` branch. Signed-off-by: Chris Evich <cevich@redhat.com>
Signed-off-by: Chris Evich <cevich@redhat.com>
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: cevich The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Member
Author
|
Ref: Workflow log with the too-long "DO NOT MERGE: ..." commit 26a4c1c. |
cevich
force-pushed
the
fix_commit_validation_workflow
branch
from
26a4c1c to
614666c
Compare
|
Ephemeral COPR build failed. @containers/packit-build please check. |
Member
Author
|
Ref: Workflow log without the too-long "DO NOT MERGE: ..." |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind other
What this PR does / why we need it:
Fix commit title-length checking workflow bug
How to verify it
The workflow will fail on this PR when the very long 'DO NOT MERGE:...' commit is included. But the workflow will pass when that commit is removed.
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Does this PR introduce a user-facing change?