[WIP] Enable building Windows container images #6592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
do-not-merge/work-in-progress
kind/feature
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sebsoto The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Adds layerWriter, a struct meant to encapsulate the Writer pipeline for writing a container layers to disk. This is a refactor meant to reduce the code complexity of containerImageRef.NewImageSource(). Signed-off-by: Sebastian Soto <ssoto@redhat.com>
sebsoto
force-pushed
the
windowsWork
branch
5 times, most recently
from
9c4aa2c to
0d130f7
Compare
Enables committing a Windows base image as the final layer. This gives the possibility of building a Windows container image on a Linux build system. Only COPY and ADD are in scope. This allows the workflow of cross compiling Windows binaries on Linux, and copying them into a Windows container image for use on Windows systems. Signed-off-by: Sebastian Soto <ssoto@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
How to verify it
Which issue(s) this PR fixes:
Fixes #4010
Special notes for your reviewer:
Does this PR introduce a user-facing change?