update flex attention patching for transformers 4.51 #2501
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to be in line with transformers v4.51
Contributor
|
huggingface/transformers#37285 has landed btw |
bursteratom
force-pushed
the
flex_patching_update
branch
from
b98dbaf to
cdb1606
Compare
winglian
reviewed
Apr 10, 2025
Collaborator
There was a problem hiding this comment.
I don't know that this can be removed yet, as the released version in transformers had an edge case that affects most of our docker builds. huggingface/transformers#37399
NanoCode012
reviewed
Apr 22, 2025
Comment on lines
-909
to
-913
| if self.cfg.flex_attention: | ||
| self.model_kwargs["attn_implementation"] = "flex_attention" | ||
| self.model_config._attn_implementation = ( # pylint: disable=protected-access | ||
| "flex_attention" | ||
| ) |
Collaborator
There was a problem hiding this comment.
Do we need to at least keep these lines?
Contributor
There was a problem hiding this comment.
Do we still even need this PR?
Collaborator
|
superseded by #2469 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumping flex attention monkeypatch to transformers 4.51