Skip to content

Conversation

@jmshea
Copy link
Contributor

@jmshea jmshea commented Mar 11, 2023

See jupyterlite/jupyterlite#818

Note that I bumped the minimum Python version to 3.8 because SciPy would not install without that change.

See jupyterlite/jupyterlite#818

Note that I bumped the minimum Python version to 3.8 because SciPy
would not install without that change.
@kolibril13
Copy link
Member

Thanks!

@kolibril13 kolibril13 merged commit 475b04b into Octoframes:main Mar 11, 2023
@kolibril13
Copy link
Member

Hi @jmshea !
Seems like the setuptools approach was causing some problems with GoogleColab:
#47
I saw that you got an alternativ solution in jupyterlite/jupyterlite#818 (comment), the question:
Would you have some free minutes to implement the importlib.resources instead of setuptools approach here as well?
That would be an amazing contribution!
I removed the setuptools dependency already.

@jmshea
Copy link
Contributor Author

jmshea commented Mar 13, 2023

Sure, I can do it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants