Skip to content

Rework dynamic icons (AIChatIcon, AISearchIcon) #3853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zenoachtig merged 3 commits into from
Dec 9, 2025
Merged

Rework dynamic icons (AIChatIcon, AISearchIcon) #3853

zenoachtig merged 3 commits into from
Dec 9, 2025
+114 −66

Conversation

@zenoachtig
Copy link
Contributor

@zenoachtig zenoachtig commented Dec 8, 2025 •
edited
Loading

Better rendering of conditional icons (for the done, confirm, and error states) and cleanup of the code

@zenoachtig zenoachtig requested a review from SamyPesse December 8, 2025 12:08
@changeset-bot
Copy link

changeset-bot bot commented Dec 8, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 7c276d8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@zenoachtig zenoachtig changed the title Move dynamic icons (AIChatIcon and AISearchIcon) to @gitbook/icons … Move dynamic icons (AIChatIcon and AISearchIcon) to @gitbook/icons Dec 8, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2025 •
edited
Loading

Summary of the deployments:

Version URL Status
Vercel https://gitbook-v2-gr3v46syj-gitbook.vercel.app ✅
Cloudflare https://8e1b90bb-gitbook-open-v2-preview.gitbook.workers.dev ✅

Test content

Site 2v 2c
GitBook https://gitbook-v2-gr3v46syj-gitbook.vercel.app/url/gitbook.com/docs https://8e1b90bb-gitbook-open-v2-preview.gitbook.workers.dev/url/gitbook.com/docs
E2E https://gitbook-v2-gr3v46syj-gitbook.vercel.app/url/gitbook.gitbook.io/test-gitbook-open https://8e1b90bb-gitbook-open-v2-preview.gitbook.workers.dev/url/gitbook.gitbook.io/test-gitbook-open

@argos-ci
Copy link

argos-ci bot commented Dec 8, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
customers-v2 (Inspect) ✅ No changes detected - Dec 8, 2025, 10:30 PM
v2-cloudflare (Inspect) 👍 Changes approved 18 changed Dec 8, 2025, 10:34 PM
v2-vercel (Inspect) 👍 Changes approved 13 changed Dec 8, 2025, 10:33 PM

@zenoachtig zenoachtig changed the title Move dynamic icons (AIChatIcon and AISearchIcon) to @gitbook/icons Rework dynamic icons Dec 8, 2025
@zenoachtig zenoachtig removed the request for review from SamyPesse December 8, 2025 22:24
@zenoachtig zenoachtig changed the title Rework dynamic icons Rework dynamic icons (AIChatIcon, AISearchIcon) Dec 9, 2025
@zenoachtig zenoachtig merged commit 44feb3b into main Dec 9, 2025
19 of 20 checks passed
@zenoachtig zenoachtig deleted the dynamic-icons branch December 9, 2025 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sdirosa sdirosa sdirosa approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zenoachtig @sdirosa