Skip to content

Fixed typo Error as well local variable in Day 9 and Day 11 .md files #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Sarvesh1523 wants to merge 1 commit into from
Closed

Fixed typo Error as well local variable in Day 9 and Day 11 .md files #105

Sarvesh1523 wants to merge 1 commit into from

Conversation

@Sarvesh1523
Copy link

@Sarvesh1523 Sarvesh1523 commented Oct 2, 2020

  • Day 9 - MD files have 2 bugs which are related to the scope, need to use the local variable inside the function but used global variable instead.
  • Dar 11 - MD file have 2 bugs which were variable naming error due to typo.

I have fixed those 4 bugs.

KamrulSh
KamrulSh approved these changes Oct 14, 2020
View reviewed changes
Copy link

@KamrulSh KamrulSh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked all files. Day 9 may not have changed.

11_Day_Destructuring_and_spreading/11_day_destructuring_and_spreading.md
```js
const names = ['Asabeneh', 'Brook', 'David', 'John']
let [firstPerson, secondPerson, thirdPerson, fourth Person] = names
let [firstPerson, secondPerson, thirdPerson, fourthPerson] = names
Copy link

@KamrulSh KamrulSh Oct 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is the duplicate of the pull request #104 .

@Asabeneh Asabeneh closed this Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@KamrulSh KamrulSh KamrulSh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Sarvesh1523 @KamrulSh @Asabeneh